[ARROW-8862] [C++] NumericBuilder does not use MemoryPool passed to CTOR

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.15.0
• Fix Version/s: 1.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25000
• Assignee: Simon Watts
• Reporter: Simon Watts
• Created: 19/May/20 19:53
• Updated: 11/Jan/23 08:03
• Resolved: 19/May/20 21:59

Description

NumericBuilder uses the pool (MemoryPool*) parameter to initialise the ArrayBuilder base class, but does not use it to initialise its own internal builder, data_builder_ (TypedBufferBuilder). For comparison ArrayBuilder uses the pool to initialise its own null_bitmap_builder_ member (also a TypedBufferBuilder).

Found in version 0.15.0, present in current head.

This effect was observed when trying to switch to a custom MemoryPool for performance reasons. A hook was used to detect any use of the MemoryPool proved by default_memory_pool().

Issue Links

• links to: GitHub Pull Request #7227