Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-85

C++: memcmp can be avoided in Equal when comparing with the same Buffer

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.1.0
    • C++
    • None

    Description

      It looks too expensive to use memcmp to compare two buffers. Instead, the starting address and length/capacity would be good enough to use. Higher level codes relying on memcmp behaviour can be done in higher level.

      Update: memcmp should be avoided in Equal when comparing with the same Buffer. In other cases, it's still needed to know the content are the same or not.

      Attachments

        Activity

          People

            drankye Kai Zheng
            drankye Kai Zheng
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: