[ARROW-8198] [C++] Diffing should handle null arrays

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.15.0
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/24397
• Assignee: Ben Kietzman
• Reporter: Antoine Pitrou
• Created: 24/Mar/20 17:18
• Updated: 11/Jan/23 07:58
• Resolved: 31/Mar/20 09:35

Description

When AssertArraysEqual fails between arrays of type null, you get the rather unhelpful message:

../src/arrow/compare.cc:964:  Check failed: _s.ok() Operation failed: PrintDiff(left, right, opts.diff_sink())
Bad status: NotImplemented: formatting diffs between arrays of type null
In ../src/arrow/array/diff.cc, line 453, code: VisitTypeInline(type, this)
In ../src/arrow/array/diff.cc, line 825, code: (_error_or_value10).status()
In ../src/arrow/compare.cc, line 955, code: (_error_or_value4).status()

Issue Links

• links to: GitHub Pull Request #6763