[ARROW-8129] [C++][Compute] Refine compare sorting kernel

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/24336
• Assignee: Yibo Cai
• Reporter: Yibo Cai
• Created: 16/Mar/20 08:33
• Updated: 11/Jan/23 07:58
• Resolved: 17/Mar/20 12:48

Description

Sorting kernel implements two comparison functions, CompareValues use array.Value() for numeric data and CompareViews uses array.GetView() for non-numeric ones. It can be simplified by using GetView() only as all data types support GetView().

To my surprise, benchmark shows about 40% performance improvement after the change.

After some digging, I find in current code, the comparison callback is not inlined (check disassembled code), it leads to a function call. It's very bad for this hot loop. Using only GetView() fixes this issue, code inlined okay.

Issue Links

• links to: GitHub Pull Request #6640