Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-8125

[C++] "arrow-tests" target broken with ninja build

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.17.0
    • C++

    Description

      $ ninja arrow-tests
      ninja: no work to do.
      

      According to git bisect this was introduced by

      $ git bisect bad
      7db3855cd4a2e2f704b8715af3a36cbef0bb2a27 is the first bad commit
      commit 7db3855cd4a2e2f704b8715af3a36cbef0bb2a27
      Author: Benjamin Kietzman <bengilgit@gmail.com>
      Date:   Mon Mar 9 16:40:21 2020 +0100
      
          ARROW-8014: [C++] Provide CMake targets exercising tests with a label
          
          To run a subset of the tests, use:
          ```shell-session
          $ ninja -C ~/arrow/cpp/debug-build test-arrow_dataset
          ```
          
          Closes #6547 from bkietz/8014-Provide-CMake-targets-to- and squashes the following commits:
          
          cf9bbb06a <Benjamin Kietzman> test-lable- => test-
          90a1a7f3b <Benjamin Kietzman> ARROW-8014:  Provide Cmake targets exercising tests with a label
          
          Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
          Signed-off-by: Antoine Pitrou <antoine@python.org>
      
       cpp/cmake_modules/BuildUtils.cmake | 15 +++++++++++++++
       cpp/src/arrow/CMakeLists.txt       |  2 --
       2 files changed, 15 insertions(+), 2 deletions(-)
      

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h