[ARROW-7975] [C++] Do not include padding bytes in "Buffer" IPC metadata accounting

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17071
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 02/Mar/20 05:17
• Updated: 11/Jan/23 07:57
• Resolved: 02/Mar/20 22:01

Description

At this line, we include the padding bytes into the IPC metadata

https://github.com/apache/arrow/blob/apache-arrow-0.16.0/cpp/src/arrow/ipc/writer.cc#L192

The effect of this is that buffer sizes are modified by an IPC roundtrip. According to the Format, the padding bytes do not need to be accounted for in the metadata.

https://github.com/apache/arrow/blob/master/format/Schema.fbs#L330

The Java implementation, for example, does not.

I ran into this when working on a prototype implementation of ARROW-300, where it is important to have the exact unpadded size of the original buffer that was written.

Issue Links

• links to: GitHub Pull Request #6513