Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7798

[R] Refactor R <-> Array conversion

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 5.0.0
    • Component/s: R
    • Labels:
      None

      Description

      There's a bit of technical debt accumulated in array_to_vector and vector_to_array:

      • Mix of conversion and casting, ideally we'd move casting out of there (at the cost of more memory copy). The rationale is that the conversion logic will differ from the CastKernels, e.g. when to raise errors, benefits from complex conversions like timezone... The current implementation is fast, e.g. it fuses the conversion and casting in a single loop at the cost of code clarity and divergence.
      • There should be 2 paths, zero-copy, non zero-copy. The non-zero copy should use the newly introduced VectorToArrayConverter which will work with complex nested types.
      • The in array_to vector, Converter should work primarily with Array and not ArrayVector
      • The vector_to_array should not use builders, sizes are known, the null bitmap should be constructed separately. There's probably a chance that we can re-use R's memory with zero-copy for the raw data.
      • There seem to be multiple paths that do the same conversion: https://github.com/apache/arrow/pull/7514#discussion_r446706140

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                romainfrancois Romain Francois
                Reporter:
                fsaintjacques Francois Saint-Jacques
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: