[ARROW-7664] [C++] Extract localfs default from FileSystemFromUri

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.15.1
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17034
• Assignee: Antoine Pitrou
• Reporter: Ben Kietzman
• Created: 23/Jan/20 18:53
• Updated: 11/Jan/23 07:55
• Resolved: 24/Feb/20 15:42

Description

https://github.com/apache/arrow/pull/6257#pullrequestreview-347506792

The argument to FileSystemFromUri should always be rfc3986 formatted. The current fallback to localfs can be recovered by adding static string Uri::FromPath(string) which wraps uriWindowsFilenameToUriStringA and the corresponding unix path function.

FileSystemFromUri(Uri::FromPath(R"(E:\dir\file.txt)"), &sanitized) 

This is a little more boilerplate but I think it's worthwhile to be explicit here.

Issue Links

• links to: GitHub Pull Request #6446