Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7516

[C#] .NET Benchmarks are broken

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.16.0
    • C#

    Description

      See https://github.com/apache/arrow/pull/6030#issuecomment-571877721

       

      It looks like the issue is that in the Benchmarks, `Length` is specified as `1_000_000`, and there has only been ~730,000 days since `DateTime.Min`, so this line fails:

      https://github.com/apache/arrow/blob/4634c89fc77f70fb5b5d035d6172263a4604da82/csharp/test/Apache.Arrow.Tests/TestData.cs#L130

      A simple fix would be to cap what we pass into `AddDays` to some number like `100_000`, or so.

      Attachments

        Issue Links

          Activity

            People

              eerhardt Eric Erhardt
              eerhardt Eric Erhardt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Time Spent - 0.5h Remaining Estimate - 1.5h
                  1.5h
                  Logged:
                  Time Spent - 0.5h Remaining Estimate - 1.5h
                  0.5h