[ARROW-7338] [C++] Improve InMemoryDataSource to support generator instead of static list

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: dataset
• External issue URL: https://github.com/apache/arrow/issues/23619
• Assignee: Ben Kietzman
• Reporter: Francois Saint-Jacques
• Created: 06/Dec/19 15:31
• Updated: 11/Jan/23 07:53
• Resolved: 23/Feb/20 13:14

Description

The constructor should take a generator

// Some comments here
class InMemoryDataSource : public DataSource {
  public:
    using Generator = std::function<Iterator<std::shared_ptr<RecordBatch>()>;

    InMemoryDataSource(Generator&& generator);
    // Convenience constructor to support a fixed list of RecordBatch
    InMemoryDataSource(std::shared_ptr<RecordBatch>);
    InMemoryDataSource(std::vector<std::shared_ptr<RecordBatch>>);

private:
  Generator generator;
}