Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7332

[C++][Parquet] Explicitly catch status exceptions in PARQUET_CATCH_NOT_OK

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.15.1
    • 0.17.0
    • C++

    Description

      PARQUET_THROW_NOT_OK throws a ParquetStatusException, which contains a full Status rather than just an error string. These could be caught explicitly in PARQUET_CATCH_NOT_OK and the original status returned rather than creating a new status:

        } catch (const ::parquet::ParquetStatusException& e) { \
          return e.status(); \
        } catch (const ::parquet::ParquetException& e) { \
          return Status::IOError(e.what()) \
      

      This will retain the original StatusCode rather than overwriting it with IOError.

      Attachments

        Issue Links

          Activity

            People

              apitrou Antoine Pitrou
              bkietz Ben Kietzman
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h