Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7303

[C++] Refactor benchmarks to use new Result APIs

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.15.1
    • Fix Version/s: 0.16.0
    • Component/s: C++

      Description

      When building benchmarks, I get the following error:

      ../src/arrow/csv/converter_benchmark.cc:83:64: error: too many arguments to function call, expected 2, have 3
          ABORT_NOT_OK(converter->Convert(parser, 0 /* col_index */, &result));
      

      This was introduced by ARROW-7236. I guess the CI didn't catch it because we don't currently build benchmarks? Antoine Pitrou Krisztian Szucs

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bkietz Ben Kietzman
                Reporter:
                bkietz Ben Kietzman
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h