Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7036

[C++] Version up ORC to avoid compile errors

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.16.0
    • Component/s: C++

      Description

      I encountered the compile errors due to -Wshadow-field like below:

      [1/4] Building CXX object c++/src/CMakeFiles/orc.dir/Vector.cc.o
      FAILED: c++/src/CMakeFiles/orc.dir/Vector.cc.o
      /Applications/Xcode_11.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++   -Ic++/include -I/Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/include -I/Users/mrkn/src/github.com/apa
      che/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src -Ic++/src -isystem c++/libs/thirdparty/zlib_ep-install/include -isystem c++/libs/thirdparty/lz4_ep-install/include -Qunused-arguments -fcolor-diagnostics -ggdb -O0 -g -fPIC  -Wno-z
      ero-as-null-pointer-constant -Wno-inconsistent-missing-destructor-override -Wno-error=undef -std=c++11 -Weverything -Wno-c++98-compat -Wno-missing-prototypes -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default -Wno-missing-n
      oreturn -Wno-unknown-pragmas -Wno-gnu-zero-variadic-macro-arguments -Wconversion -Werror -std=c++11 -Weverything -Wno-c++98-compat -Wno-missing-prototypes -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default -Wno-missing-nore
      turn -Wno-unknown-pragmas -Wno-gnu-zero-variadic-macro-arguments -Wconversion -Werror -O0 -g -MD -MT c++/src/CMakeFiles/orc.dir/Vector.cc.o -MF c++/src/CMakeFiles/orc.dir/Vector.cc.o.d -o c++/src/CMakeFiles/orc.dir/Vector.cc.o -c /Users/mr
      kn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src/Vector.cc
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src/Vector.cc:59:45: error: parameter 'capacity' shadows member inherited from type 'ColumnVectorBatch' [-Werror,-Wshadow-field]
        LongVectorBatch::LongVectorBatch(uint64_t capacity, MemoryPool& pool
                                                  ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/include/orc/Vector.hh:46:14: note: declared here
          uint64_t capacity;
                   ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src/Vector.cc:87:49: error: parameter 'capacity' shadows member inherited from type 'ColumnVectorBatch' [-Werror,-Wshadow-field]
        DoubleVectorBatch::DoubleVectorBatch(uint64_t capacity, MemoryPool& pool
                                                      ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/include/orc/Vector.hh:46:14: note: declared here
          uint64_t capacity;
                   ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src/Vector.cc:115:49: error: parameter 'capacity' shadows member inherited from type 'ColumnVectorBatch' [-Werror,-Wshadow-field]
        StringVectorBatch::StringVectorBatch(uint64_t capacity, MemoryPool& pool
                                                      ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/include/orc/Vector.hh:46:14: note: declared here
          uint64_t capacity;
                   ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/src/Vector.cc:407:55: error: parameter 'capacity' shadows member inherited from type 'ColumnVectorBatch' [-Werror,-Wshadow-field]
        TimestampVectorBatch::TimestampVectorBatch(uint64_t capacity,
                                                            ^
      /Users/mrkn/src/github.com/apache/arrow/cpp/build.debug/orc_ep-prefix/src/orc_ep/c++/include/orc/Vector.hh:46:14: note: declared here
          uint64_t capacity;
                   ^
      4 errors generated.
      

      Upgrading ORC to 1.5.7 will fix this errors.

      I used Xcode 11.1 on macOS Mojave.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mrkn Kenta Murata
                Reporter:
                mrkn Kenta Murata
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m