[ARROW-6781] [C++] Improve and consolidate ARROW_CHECK, DCHECK macros

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/23118
• Assignee: Unassigned
• Reporter: Ben Kietzman
• Created: 03/Oct/19 15:23
• Updated: 11/Jan/23 07:49

Description

Currently we have multiple macros like DCHECK_EQ and DCHECK_LT which check various comparisons but don't report anything about their operands. Furthermore, the "stream to assertion" pattern for appending extra info has proven fragile. I propose a new unified macro which can capture operands of comparisons and report them:

  int three = 3;
  int five = 5;
  DCHECK(three == five, "extra: ", 1, 2, five);

Results in check failure messages like:

F1003 11:12:46.174767  4166 logging_test.cc:141]  Check failed: three == five
  LHS: 3
  RHS: 5
extra: 125

Issue Links

• links to: GitHub Pull Request #8735