[ARROW-6711] [C++] Consolidate Filter and Expression classes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.16.0
• Component/s: C++
• Labels: dataset pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/23055
• Assignee: Ben Kietzman
• Reporter: Ben Kietzman
• Created: 26/Sep/19 14:23
• Updated: 11/Jan/23 07:48
• Resolved: 11/Oct/19 18:24

Description

There is unnecessary boilerplate required when using the Filter/Expression classes. Filter is no longer necessary; it (and FilterVector) can be replaced with Expression. Expression is sufficiently general that it can be subclassed to provide any custom functionality which would have been added through a GenericFilter (add some tests for this).

Additionally rows within RecordBatches yielded from a scan are not currently filtered using Expression::Evaluate(). (Add tests ensuring both row filtering and pruning obey Kleene logic)

Add some comments on the mechanism of Assume() too, and refactor it not to return a Result (its failure modes are covered by Validate())

Issue Links

• links to: GitHub Pull Request #5594