[ARROW-6525] [C++] CloseFromDestructor() should perhaps not crash

• Type: Wish
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.15.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/16874
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 11/Sep/19 09:14
• Updated: 11/Jan/23 07:47
• Resolved: 12/Sep/19 11:41

Description

When a stream object fails to close in its destructor, CloseFromDestructor() will abort the process with a fatal error. This may not be desirable on e.g. networked filesystems where failing to closing isn't uncommon. Perhaps we should just log an error instead.

(stream users should generally call Close() explicitly, but in some cases they may fail to do so, e.g. when an error interrupts processing)

Issue Links

• links to: GitHub Pull Request #5352