[ARROW-6479] [C++] inline errors from external projects' build logs

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22848
• Assignee: Ben Kietzman
• Reporter: Ben Kietzman
• Created: 06/Sep/19 16:22
• Updated: 11/Jan/23 07:47
• Resolved: 02/Apr/20 17:24

Description

Currently when an external project build fails, we get a very uninformative message:

[88/543] Performing build step for 'flatbuffers_ep'
FAILED: flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build flatbuffers_ep-prefix/src/flatbuffers_ep-install/bin/flatc flatbuffers_ep-prefix/src/flatbuffers_ep-install/lib/libflatbuffers.a 
cd /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-build && /usr/bin/cmake -P /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build-DEBUG.cmake && /usr/bin/cmake -E touch /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build
CMake Error at /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build-DEBUG.cmake:16 (message):
  Command failed: 1

   '/usr/bin/cmake' '--build' '.'

  See also

    /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build-*.log

It would be far more useful if the error were caught and relevant section (or even the entirity) of {{ /build/cpp/flatbuffers_ep-prefix/src/flatbuffers_ep-stamp/flatbuffers_ep-build-*.log}} were output instead. This is doubly the case on CI where accessing those logs is non trivial

Issue Links

• relates to: ARROW-5473 [C++] Build failure on googletest_ep on Windows when using Ninja
• links to: GitHub Pull Request #6813