[ARROW-6458] [Java] Remove value boxing/unboxing for ApproxEqualsVisitor

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.15.0
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22828
• Assignee: Liya Fan
• Reporter: Liya Fan
• Created: 05/Sep/19 03:56
• Updated: 11/Jan/23 07:47
• Resolved: 17/Sep/19 04:40

Description

As discussed in https://github.com/apache/arrow/pull/5195#issuecomment-526157961, there are some problems with the current ways of comparing floating point vectors, we solve them in this PR:

1. there are if statements/duplicated members in ApproxEqualsVisitor, making the code redundant and less clear.
2. the comparion of float4 and float8 are based on wrapped objects Float and Double, which may have performance penalty.

Issue Links

• links to: GitHub Pull Request #5304