[ARROW-6425] [C++] ValidateArray fail for slice of list array

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.14.1
• Fix Version/s: 0.15.0
• Component/s: C++
• External issue URL: https://github.com/apache/arrow/issues/22795
• Assignee: Wes McKinney
• Reporter: Yan Zhou
• Created: 03/Sep/19 13:00
• Updated: 11/Jan/23 07:47
• Resolved: 04/Sep/19 10:15

Description

The ValidateArray function fails for slice of list array (and MapArray I believe though haven't tested it yet). The validation will only pass for an unsliced array or the last slice.

 

For example,

 

 

auto value_builder = std::make_shared<::arrow::DoubleBuilder>();
    ::arrow::ListBuilder builder(
        ::arrow::default_memory_pool(), value_builder);
    auto status = builder.Append(true);
    status = value_builder->Append(1);
    status = builder.Append(true);
    status = value_builder->Append(2);
    std::shared_ptr<::arrow::Array> list;
    status = builder.Finish(&list);
    std::cout << ::arrow::ValidateArray(*list).ok() << std::endl;
    std::cout << ::arrow::ValidateArray(*list->Slice(0, 1)).ok() << std::endl;
    std::cout << ::arrow::ValidateArray(*list->Slice(1, 1)).ok() << std::endl;
 

 

This will print 1, 0, 1.

 

The problem lies in array.cc around line 1167

 

    const int32_t last_offset = array.value_offset(array.length());
    if (array.values()->length() != last_offset) {
      return Status::Invalid("Final offset invariant not equal to values length: ",
                             last_offset, "!=", array.values()->length());
    }

Here values() does not account for the array offset and thus its length is the whole array while value_offset and array.length() will account for that offset.

Issue Links

• duplicates: ARROW-6174 [C++] Validate chunks in ChunkedArray::Validate