Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-6337

[R] as_tibble in R API is a misnomer

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15.0
    • Component/s: R

      Description

      As of ARROW-5190, the R package's dependency on tibble has been moved from Imports to Suggests. However, this signature of read_parquet(), read_delim_arrow(), read_json_arrow(), and read_feather() all still have an argument called "as_tibble".

      Per this comment the argument "as_tibble" is a misnomer. If that argument is given a TRUE, those functions will return a data.frame, not a tibble. I agree with Neal's comment...I think that instead of changing return type based on a boolean, it would be better for all the read_* functions to return a data.frame and for other types of operations to get their own functions.

      I think it's important to consider this type of user-facing breaking change now while the R package's version is still 0.x.

      As always, thanks for hearing me out!

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jameslamb James Lamb
                Reporter:
                jameslamb James Lamb
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 20m
                  1h 20m