Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-6299

[C++] Simplify FileFormat classes to singletons

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: C++
    • Labels:

      Description

      ParquetFileFormat has no state, so passing it around by shared_ptr<FileFormat> is not necessary; we could just keep a single static instance and pass raw pointers.

      [~wesmckinn] is there a case where a FileFormat might have state?

        Attachments

          Activity

            People

            • Assignee:
              bkietz Ben Kietzman
              Reporter:
              bkietz Ben Kietzman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: