[ARROW-5754] [C++]Missing override for ~GrpcStreamWriter?

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22179
• Assignee: Kenta Murata
• Reporter: Kenta Murata
• Created: 27/Jun/19 05:42
• Updated: 11/Jan/23 07:42
• Resolved: 27/Jun/19 08:15

Description

I encountered the following compile error:

../src/arrow/flight/client.cc:244:3: error: '~GrpcStreamWriter' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
  ~GrpcStreamWriter() = default;
  ^
../src/arrow/flight/client.h:86:27: note: overridden virtual function is here
class ARROW_FLIGHT_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter {
                          ^

Putting override modifier can resolve this problem.
I'll make a pull-request for the change.

Issue Links

• links to: GitHub Pull Request #4716