[ARROW-5404] [C++] nonstd::string_view conflicts with std::string_view in c++17

• Type: New Feature
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/16742
• Assignee: Ben Kietzman
• Reporter: Ben Kietzman
• Created: 23/May/19 13:24
• Updated: 11/Jan/23 07:40
• Resolved: 23/May/19 17:14

Description

From GitHub issue https://github.com/apache/arrow/issues/4294

Our vendored string_view header will forward to std::string_view if that is available. This can produce ABI conflicts and build errors when arrow or applications which use it are built against c++17.

I think it's acceptable to just force usage of nonstd's implementation with #define nssv_CONFIG_SELECT_STRING_VIEW nssv_STRING_VIEW_NONSTD

Issue Links

• links to: GitHub Pull Request #4378