[ARROW-5403] [C++] Test failures not propagated in Windows shared builds

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21858
• Assignee: Wes McKinney
• Reporter: Antoine Pitrou
• Created: 23/May/19 12:14
• Updated: 11/Jan/23 07:40
• Resolved: 30/May/19 23:55

Description

See https://github.com/google/googletest/issues/2261

Try e.g. this change:

diff --git a/cpp/src/arrow/buffer-test.cc b/cpp/src/arrow/buffer-test.cc
index 9b0530e5c..ce7628f55 100644
--- a/cpp/src/arrow/buffer-test.cc
+++ b/cpp/src/arrow/buffer-test.cc
@@ -35,6 +35,10 @@
 namespace arrow {

 TEST(TestAllocate, Bitmap) {
+  auto buf1 = Buffer::FromString("a");
+  auto buf2 = Buffer::FromString("b");
+  AssertBufferEqual(*buf1, *buf2);
+
   std::shared_ptr<Buffer> new_buffer;
   ARROW_EXPECT_OK(AllocateBitmap(default_memory_pool(), 100, &new_buffer));
   EXPECT_GE(new_buffer->size(), 13);

On a Windows shared library build, it outputs this:

[==========] Running 31 tests from 11 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from TestAllocate
[ RUN      ] TestAllocate.Bitmap
..\src\arrow\testing\gtest_util.cc(120): error: Value of: buffer.Equals(expected
)
  Actual: false
Expected: true
[       OK ] TestAllocate.Bitmap (0 ms)
[ RUN      ] TestAllocate.EmptyBitmap
[       OK ] TestAllocate.EmptyBitmap (0 ms)
[----------] 2 tests from TestAllocate (0 ms total)

.... and the entire test file is marked passed.

Issue Links

• links to: GitHub Pull Request #4380