[ARROW-5264] [Java] Allow enabling/disabling boundary checking by environmental variable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21735
• Assignee: Liya Fan
• Reporter: Liya Fan
• Created: 06/May/19 07:53
• Updated: 11/Jan/23 07:39
• Resolved: 10/May/19 12:55

Description

The flag BoundsChecking#BOUNDS_CHECKING_ENABLED determines if boundary checking is enabled/disabled in vector/arrow buffer APIs.
It has significant performance implications, since boundary checking is a frequent operation.

This issue addresses 2 problems with the flag for boundary checking in Java API:

1. The flag can be determined by an environmental variable: ARROW_ENABLE_UNSAFE_MEMORY_ACCESS, in addition to the system properties. The system properties have higher priority than the environmental variable.

2. There is an old and a new system property for this flag. To disable boundary checking, both the old and new properties must be set to true, which is undesirable:

Issue Links

• relates to: ARROW-4851 [Java] BoundsChecking.java defaulting behavior for old drill parameter seems off
• links to: GitHub Pull Request #4258