[ARROW-5194] [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing

• Type: Test
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: C++ - Plasma
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21670
• Assignee: Guillaume Horel
• Reporter: Guillaume Horel
• Created: 22/Apr/19 17:52
• Updated: 11/Jan/23 07:38
• Resolved: 27/Jun/19 07:39

Description

I believe the assertions here are incorrect. You can't use memcmp to compare structs
On my machine (64bits linux) int are 4 bytes, but the struct fields are 8 bytes aligned, so this line fails:

ASSERT_EQ(memcmp(&plasma_objects[object_ids[0]], &plasma_objects_return[0],
sizeof(PlasmaObject)),
0);

even though the struct contents are the same.

Issue Links

• is duplicated by: ARROW-5036 [Plasma][C++] Serialization tests resort to memcpy to check equality
• links to: GitHub Pull Request #4203