[ARROW-5059] [C++][Gandiva] cbrt_* floating point tests can fail due to exact comparisons

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 0.14.0
• Component/s: C++ - Gandiva
• External issue URL: https://github.com/apache/arrow/issues/21551
• Assignee: Praveen Kumar
• Reporter: Wes McKinney
• Created: 28/Mar/19 21:28
• Updated: 11/Jan/23 07:38
• Resolved: 29/Mar/19 07:15

Description

I observed this when running the release verification on Ubuntu 14.04

[ RUN      ] TestExtendedMathOps.TestCbrt
/tmp/arrow-0.13.0.WeWDY/apache-arrow-0.13.0/cpp/src/gandiva/precompiled/extended_math_ops_test.cc:27: Failure
      Expected: cbrt_float32(27)
      Which is: 3
To be equal to: 3
/tmp/arrow-0.13.0.WeWDY/apache-arrow-0.13.0/cpp/src/gandiva/precompiled/extended_math_ops_test.cc:28: Failure
      Expected: cbrt_float64(27)
      Which is: 3
To be equal to: 3
/tmp/arrow-0.13.0.WeWDY/apache-arrow-0.13.0/cpp/src/gandiva/precompiled/extended_math_ops_test.cc:29: Failure
      Expected: cbrt_float64(-27)
      Which is: -3
To be equal to: -3

The tests in question:

TEST(TestExtendedMathOps, TestCbrt) {
  EXPECT_EQ(cbrt_int32(27), 3);
  EXPECT_EQ(cbrt_int64(27), 3);
  EXPECT_EQ(cbrt_float32(27), 3);
  EXPECT_EQ(cbrt_float64(27), 3);
  EXPECT_EQ(cbrt_float64(-27), -3);

  EXPECT_EQ(cbrt_float32(15.625), 2.5);
  EXPECT_EQ(cbrt_float64(15.625), 2.5);
}

I believe that assertions involving floating point equality need to be approximate (up to a typical epsilon like 1E-14/1E-15)

Issue Links

• is duplicated by: ARROW-4959 [Gandiva][Crossbow] Builds broken