[ARROW-4997] [C#] ArrowStreamReader doesn't consume whole stream and doesn't implement sync read

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C#
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21497
• Assignee: Eric Erhardt
• Reporter: Eric Erhardt
• Created: 22/Mar/19 11:53
• Updated: 11/Jan/23 07:37
• Resolved: 22/Mar/19 21:25

Description

There are 2 major issues with the ArrowStreamReader that are blocking me from using it.

1. When it reads a batch from a .NET Stream that doesn't return the whole chunk of memory in one "Read" call (like a socket/network stream), it only calls Read once, and then continues on. This is an issue because it has "garbage" at the end of its buffer (which was never written to by the stream), and when attempting to read the next batch, it is in the middle of the previous batch from the .NET Stream. This causes all sorts of issues because it assumes the next 4 bytes are the message length, which it obviously isn't. See the reading code for where it only calls Read once - it should be in a loop.
2. ArrowStreamReader has a synchronous ReadNextRecordBatch() method - but it throws NotImplementedException. This is necessary when a caller isn't in an async method, they can't/shouldn't call the async API.

Issue Links

• links to: GitHub Pull Request #4017