[ARROW-4811] [C++] An incorrect dependency leads "ninja" to re-evaluate steps unnecessarily on subsequent calls

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21328
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 08/Mar/19 23:16
• Updated: 11/Jan/23 07:36
• Resolved: 13/Mar/19 12:46

Description

Not sure about the root cause yet but here are the 5 steps that are re-executing

$ ninja -v
[1/5] /usr/bin/ccache /usr/bin/g++  -DARROW_EXTRA_ERROR_CONTEXT -DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR=/home/wesm/code/arrow/cpp/build/jemalloc_ep-prefix/src/jemalloc_ep/dist//include -DARROW_NO_DEPRECATED_API -DARROW_PYTHON_EXPORTING -DARROW_USE_GLOG -DARROW_USE_SIMD -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_SNAPPY -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -Isrc -I../src -isystem /home/wesm/cpp-toolchain/include -isystem gbenchmark_ep/src/gbenchmark_ep-install/include -isystem jemalloc_ep-prefix/src -isystem ../thirdparty/hadoop/include -isystem orc_ep-install/include -isystem /home/wesm/cpp-toolchain/include/thrift -isystem /home/wesm/miniconda/envs/arrow-3.7/lib/python3.7/site-packages/numpy/core/include -isystem /home/wesm/miniconda/envs/arrow-3.7/include/python3.7m -Wno-noexcept-type  -fdiagnostics-color=always -O3 -DNDEBUG  -Wall -Wno-unused-variable -msse4.2 -fno-omit-frame-pointer -O3 -DNDEBUG -fPIC   -std=gnu++11 -MD -MT src/arrow/python/CMakeFiles/arrow_python_objlib.dir/flight.cc.o -MF src/arrow/python/CMakeFiles/arrow_python_objlib.dir/flight.cc.o.d -o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/flight.cc.o -c ../src/arrow/python/flight.cc
[2/5] : && /usr/bin/ccache /home/wesm/miniconda/envs/arrow-3.7/bin/cmake -E remove release/libarrow_python.a && /usr/bin/ccache /usr/bin/ar qc release/libarrow_python.a  src/arrow/python/CMakeFiles/arrow_python_objlib.dir/arrow_to_pandas.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/benchmark.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/common.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/config.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/decimal.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/deserialize.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/helpers.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/inference.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/init.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/io.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/numpy_convert.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/numpy_to_arrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/python_to_arrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/pyarrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/serialize.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/flight.cc.o && /usr/bin/ccache /usr/bin/ranlib release/libarrow_python.a && :
[3/5] : && /usr/bin/ccache /usr/bin/g++ -fPIC -Wno-noexcept-type  -fdiagnostics-color=always -O3 -DNDEBUG  -Wall -Wno-unused-variable -msse4.2 -fno-omit-frame-pointer -O3 -DNDEBUG   -shared -Wl,-soname,libarrow_python.so.13 -o release/libarrow_python.so.13.0.0 src/arrow/python/CMakeFiles/arrow_python_objlib.dir/arrow_to_pandas.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/benchmark.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/common.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/config.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/decimal.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/deserialize.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/helpers.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/inference.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/init.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/io.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/numpy_convert.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/numpy_to_arrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/python_to_arrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/pyarrow.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/serialize.cc.o src/arrow/python/CMakeFiles/arrow_python_objlib.dir/flight.cc.o  -Wl,-rpath,/home/wesm/code/arrow/cpp/build/release:/home/wesm/cpp-toolchain/lib: -lpthread -ldl -lutil -lrt release/libarrow_flight.so.13.0.0 release/libarrow.so.13.0.0 -ldl jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a -pthread -lrt /home/wesm/cpp-toolchain/lib/libprotobuf.a /home/wesm/cpp-toolchain/lib/libgrpc++_unsecure.a /home/wesm/cpp-toolchain/lib/libgrpc_unsecure.a /home/wesm/cpp-toolchain/lib/libgpr.a /home/wesm/cpp-toolchain/lib/libaddress_sorting.a /home/wesm/cpp-toolchain/lib/libcares_static.a -Wl,-rpath-link,/home/wesm/cpp-toolchain/lib && :
[4/5] /home/wesm/miniconda/envs/arrow-3.7/bin/cmake -E cmake_symlink_library release/libarrow_python.so.13.0.0  release/libarrow_python.so.13 release/libarrow_python.so && :
[5/5] : && /usr/bin/ccache /usr/bin/g++  -Wno-noexcept-type  -fdiagnostics-color=always -O3 -DNDEBUG  -Wall -Wno-unused-variable -msse4.2 -fno-omit-frame-pointer -O3 -DNDEBUG  -rdynamic src/arrow/python/CMakeFiles/arrow-python-test.dir/python-test.cc.o  -o release/arrow-python-test  -Wl,-rpath,/home/wesm/code/arrow/cpp/build/release:/home/wesm/miniconda/envs/arrow-3.7/lib:/home/wesm/cpp-toolchain/lib release/libarrow_python_test_main.a release/libarrow_python.so.13.0.0 release/libarrow_testing.so.13.0.0 /home/wesm/miniconda/envs/arrow-3.7/lib/libpython3.7m.so -lpthread -lpthread -ldl -lutil -lrt release/libarrow_flight.so.13.0.0 /home/wesm/cpp-toolchain/lib/libprotobuf.a /home/wesm/cpp-toolchain/lib/libgrpc++_unsecure.a /home/wesm/cpp-toolchain/lib/libgrpc_unsecure.a /home/wesm/cpp-toolchain/lib/libgpr.a /home/wesm/cpp-toolchain/lib/libaddress_sorting.a /home/wesm/cpp-toolchain/lib/libcares_static.a release/libarrow.so.13.0.0 -ldl jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a -pthread -lrt /home/wesm/cpp-toolchain/lib/libgtest.a -Wl,-rpath-link,/home/wesm/cpp-toolchain/lib && :

Issue Links

• links to: GitHub Pull Request #3883