Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4648

[C++/Question] Naming/organizational inconsistencies in cpp codebase

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.15.0
    • C++

    Description

      Even after my eyes are used to the codebase, I still find the namings and/or code organization inconsistent.

      File Formats

      So arrow already support a couple of file formats, namely parquet, feather, json, csv, orc, but their placement in the codebase is quiet odd:

      • parquet: src/parquet
      • feather: src/arrow/ipc/feather
      • orc: src/arrow/adapters/orc
      • csv: src/arrow/csv
      • json: src/arrow/json
        I might misunderstand the purpose of these sources, but I'd expect them to be organized under the same roof.

      Inter-Process-Communication vs. Flight

      I'd expect flight's functionality from the ipc names.

      Flight's placement is a bit odd too, because it has its own codename, it should be placed under cpp/src - like parquet, plasma, or gandiva.

      Attachments

        Activity

          People

            apitrou Antoine Pitrou
            kszucs Krisztian Szucs
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h 50m
                3h 50m