[ARROW-4624] [C++] Linker errors when building benchmarks

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Benchmarking, C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21161
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 19/Feb/19 10:41
• Updated: 11/Jan/23 07:35
• Resolved: 19/Feb/19 13:51

Description

All C++ benchmarks now fail linking here:

[10/162] Linking CXX executable release/arrow-io-file-benchmark
FAILED: release/arrow-io-file-benchmark 
: && /usr/bin/ccache /usr/bin/g++-7  -Wno-noexcept-type  -O3 -DNDEBUG  -Wall -msse4.2 -fdiagnostics-color=always -Wextra -Wunused-result -Wno-unused-parameter -Wno-implicit-fallthrough -Wconversion -D_GLIBCXX_USE_CXX11_ABI=1 -fno-omit-frame-pointer -g -O3 -DNDEBUG  -rdynamic src/arrow/io/CMakeFiles/arrow-io-file-benchmark.dir/file-benchmark.cc.o  -o release/arrow-io-file-benchmark  release/libarrow_benchmark_main.a gbenchmark_ep/src/gbenchmark_ep-install/lib/libbenchmark.a -lpthread && :
src/arrow/io/CMakeFiles/arrow-io-file-benchmark.dir/file-benchmark.cc.o: In function `arrow::BenchmarkStreamingWrites(benchmark::State&, std::valarray<long>, arrow::io::OutputStream*, arrow::BackgroundReader*)':
/home/antoine/arrow/cpp/build/../src/arrow/io/file-benchmark.cc:139: undefined reference to `arrow::Status::ToString[abi:cxx11]() const'
/home/antoine/arrow/cpp/build/../src/arrow/io/file-benchmark.cc:63: undefined reference to `arrow::internal::FileWrite(int, unsigned char const*, long)'

[ snip tons of similar errors ]

My build script:

ARROW_CXXFLAGS="$ARROW_CXXFLAGS -fno-omit-frame-pointer -g"

mkdir -p build
pushd build

cmake .. -GNinja \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
    -DCMAKE_INSTALL_MESSAGE=LAZY \
    -DARROW_CXXFLAGS="$ARROW_CXXFLAGS" \
    -DARROW_BUILD_TESTS=off \
    -DARROW_BUILD_BENCHMARKS=on \
    -DARROW_CUDA=on \
    -DARROW_FLIGHT=on \
    -DARROW_PARQUET=on \
    -DARROW_PLASMA=off \
    -DARROW_PYTHON=on \
    -DARROW_USE_GLOG=off \

nice cmake --build . --target install

popd

Issue Links

• links to: GitHub Pull Request #3701