Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4399

[C++] Remove usage of "extern template class" from NumericArray<T>

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.13.0
    • C++

    Description

      We aren't using this to any benefit right now (only the simple constructor is being instantiated once, everything else in inline), and the rules about template visibility and linkage vary a lot between compilers, as evidenced by patches such as https://github.com/apache/arrow/pull/3503

      In general I think we should try not to use "extern template class" at all in the codebase for the problems that come with it

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m