Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4382

[C++] Improve new cpplint output readability

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Not A Problem
    • 0.12.0
    • 0.13.0
    • C++
    • None

    Description

      The output is bring printed as a _repr_ so the line breaks don't render properly

      cd /home/wesm/code/arrow/cpp/preflight-build && /home/wesm/miniconda/envs/arrow-3.7/bin/python /home/wesm/code/arrow/cpp/build-support/run_cpplint.py --cpplint_binary /home/wesm/code/arrow/cpp/build-support/cpplint.py --exclude_globs /home/wesm/code/arrow/cpp/build-support/lint_exclusions.txt --source_dir /home/wesm/code/arrow/cpp/src --quiet
      b'/home/wesm/code/arrow/cpp/src/parquet/schema.cc:68:  Add #include <algorithm> for copy  [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/schema.cc:71:  Add #include <utility> for move  [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/file_writer.cc:225:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/file_writer.cc:390:  Add #include <utility> for move  [build/include_what_you_use] [4]\n'
      b'/home/wesm/code/arrow/cpp/src/parquet/arrow/record_reader.cc:897:  Add #include <utility> for move  [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/arrow/writer.cc:1117:  Add #include <utility> for move  [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/arrow/reader.cc:1552:  Add #include <utility> for move  [build/include_what_you_use] [4]\n'
      /home/wesm/code/arrow/cpp/src/parquet/file_writer.cc: had cpplint issues
      /home/wesm/code/arrow/cpp/src/parquet/schema.cc: had cpplint issues
      /home/wesm/code/arrow/cpp/src/parquet/arrow/record_reader.cc: had cpplint issues
      /home/wesm/code/arrow/cpp/src/parquet/arrow/writer.cc: had cpplint issues
      /home/wesm/code/arrow/cpp/src/parquet/arrow/reader.cc: had cpplint issues
      ninja: build stopped: subcommand failed.
      

      Attachments

        Activity

          People

            wesm Wes McKinney
            wesm Wes McKinney
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: