[ARROW-4264] [C++] Document why DCHECKs are used in kernels

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/20841
• Assignee: Micah Kornfield
• Reporter: Micah Kornfield
• Created: 15/Jan/19 04:08
• Updated: 11/Jan/23 07:32
• Resolved: 09/Feb/19 21:01

Description

DCHECKs seem to be used where Status::Invalid might be considered more appropriate (so programs don't crash).  See conversation on https://github.com/apache/arrow/pull/3287/files

based on conversation on this Jira and on the CL it seems DCHECKS are in fact desired but we should document appropriate use for them.

Issue Links

• links to: GitHub Pull Request #3588