Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-407

BitVector.copyFromSafe() should re-allocate if necessary instead of returning false

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: Java
    • Labels:
      None

      Description

      Current implementation:

      public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
          if (outIndex >= this.getValueCapacity()) {
            decrementAllocationMonitor();
            return false;
          }
          copyFrom(inIndex, outIndex, from);
          return true;
        }
      

      doesn't match the expectation from "safe" methods. The method should try to re-allocate if it's running out of space instead of returning false

        Attachments

          Activity

            People

            • Assignee:
              adeneche Abdel Hakim Deneche
              Reporter:
              adeneche Abdel Hakim Deneche
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: