[ARROW-407] BitVector.copyFromSafe() should re-allocate if necessary instead of returning false

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Component/s: Java
• External issue URL: https://github.com/apache/arrow/issues/16056
• Assignee: Abdel Hakim Deneche
• Reporter: Abdel Hakim Deneche
• Created: 06/Dec/16 17:06
• Updated: 11/Jan/23 07:08
• Resolved: 16/Aug/17 00:58

Description

Current implementation:

public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
    if (outIndex >= this.getValueCapacity()) {
      decrementAllocationMonitor();
      return false;
    }
    copyFrom(inIndex, outIndex, from);
    return true;
  }

doesn't match the expectation from "safe" methods. The method should try to re-allocate if it's running out of space instead of returning false