Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-407

BitVector.copyFromSafe() should re-allocate if necessary instead of returning false

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.7.0
    • Java
    • None

    Description

      Current implementation:

      public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
          if (outIndex >= this.getValueCapacity()) {
            decrementAllocationMonitor();
            return false;
          }
          copyFrom(inIndex, outIndex, from);
          return true;
        }
      

      doesn't match the expectation from "safe" methods. The method should try to re-allocate if it's running out of space instead of returning false

      Attachments

        Activity

          People

            adeneche Abdel Hakim Deneche
            adeneche Abdel Hakim Deneche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: