[ARROW-4065] [C++] arrowTargets.cmake is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.12.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/20661
• Assignee: Kousuke Saruta
• Reporter: Kousuke Saruta
• Created: 18/Dec/18 08:40
• Updated: 11/Jan/23 07:31
• Resolved: 10/Jan/19 04:32

Description

When we build Arrow's cpp library using CMake, arrowTargets.cmake will be generated and installed but it's broken.

The following is a part of arrowTargets.cmake generated.

# Create imported target arrow_shared
add_library(arrow_shared SHARED IMPORTED)

set_target_properties(arrow_shared PROPERTIES
  INTERFACE_LINK_LIBRARIES "dl;pthreadshared"
)

# Create imported target arrow_static
add_library(arrow_static STATIC IMPORTED)

set_target_properties(arrow_static PROPERTIES
  INTERFACE_LINK_LIBRARIES "glog_static;zstd_static;zlib_shared;snappy_static;lz4_static;brotli_dec_static;brotli_enc_static;brotli_common_static;double-conversion_static;boost_system_shared;boost_filesystem_shared;boost_regex_shared;jemalloc_static;rt;pthreadshared"
)

There are no INTERFACE_INCLUDE_DIRECTORIES and linker doesn't recognize pthreadshared because the true name of pthread should be libpthread.so or libpthread.a.
*_static and *_shared are also wrong name.

Because of this, apps which links arrow can't be built using CMake.

Issue Links

• links to: GitHub Pull Request #3212