[ARROW-3870] [C++] Add Peek to InputStream API

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/20449
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 24/Nov/18 17:10
• Updated: 11/Jan/23 07:30
• Resolved: 02/Dec/18 04:20

Description

Some InputStream sources support lookahead without advancing the stream, like BufferReader and BufferedInputStream. This is used in Parquet's internal IO APIs, so it would be useful to be able to remove these after a deprecation cycle

https://github.com/apache/arrow/blob/master/cpp/src/parquet/util/memory.h#L375

If an InputStream does not support Peek, the returned string_view would have zero size.

Another option is to have Peek return Status, so that NotImplemented can be returned. I would prefer to return 0-length if the operation is not supported

Issue Links

• links to: GitHub Pull Request #3064