[ARROW-3793] [C++] TestScalarAppendUnsafe is not testing unsafe appends

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.12.0
• Component/s: C++
• Labels: newbie pull-request-available test
• External issue URL: https://github.com/apache/arrow/issues/20169
• Assignee: Ben Kietzman
• Reporter: Ben Kietzman
• Created: 14/Nov/18 21:44
• Updated: 11/Jan/23 07:29
• Resolved: 18/Nov/18 16:31

Description

In TestScalarAppendUnsafe, AppendNull is called to modify the bitmask which is not unsafe- it reserves at least one more element. UnsafeAppendNull should be used instead.

Since PoolBuffers round their capacities up to multiples of 64 bytes, no buffer is ever in danger of overflowing in this test anyway. More repetitions should be used so that the test will fail if insufficient storage is allocated. More storage should be allocated in the test, too- currently only a single iteration's worth is allocated.

Issue Links

• links to: GitHub Pull Request #2977