[ARROW-3662] [C++] Add a const overload to MemoryMappedFile::GetSize

• Type: New Feature
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.1
• Fix Version/s: 0.12.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/19968
• Assignee: Dimitri Vorona
• Reporter: Dimitri Vorona
• Created: 31/Oct/18 08:39
• Updated: 11/Jan/23 07:28
• Resolved: 01/Nov/18 16:49

Description

 

While GetSize in general is not a const function, it can be on a MemoryMappedFile. I propose to add a const override directly to the MemoryMappedFile.

Alternatively we could add a const version on the RandomAccessFile level which would fail, if a const size getting (e.g. without a seek) isn't possible, but it seems to me to be a potential source of hard-to-debug bugs and spurious failures. At would at least require a careful analysis of the platform support of different size getting options.

Issue Links

• links to: GitHub Pull Request #2882