Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-3540

[Rust] Incorporate BooleanArray into PrimitiveArray

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: Rust

      Description

      Currently we have a specific implementation for `BooleanArray` (bit-packing), but due to the `ArrowPrimitiveType` trait which we use as a trait bound in many places `PrimitiveArray<bool>` is still a valid type.  `make_array` actually uses `PrimitiveArray<bool>` which may be a bug but would be fixed by this issue anyway.

      I propose move the implementation of `BooleanArray` into `PrimitiveArray<bool>`, this would allow us to use the `ArrayPrimitiveType` trait as a bound more consistently.  i.e. `PrimitiveArrayBuilder<T>` could return `PrimitiveArray<T>` instead of having a separate `BooleanArrayBuilder`.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                paddyhoran Paddy Horan
                Reporter:
                paddyhoran Paddy Horan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h