Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-3522

[C++] Remove -Wconversion from build flags

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: 0.11.0
    • Fix Version/s: None
    • Component/s: C++
    • Labels:
      None

      Description

      I would request removing -Wconversion from the CI build flags. It is overly finicky, generating errors for things such as converting a size_t to double. Furthermore, gbenchmark fails building with it, making it difficult to exercise locally.

      I will mention that MSVC's conversion warnings are vastly more reasonable.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pitrou Antoine Pitrou
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: