[ARROW-3522] [C++] Remove -Wconversion from build flags

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.11.0
• Component/s: C++
• External issue URL: https://github.com/apache/arrow/issues/19838
• Assignee: Unassigned
• Reporter: Antoine Pitrou
• Created: 15/Oct/18 15:28
• Updated: 11/Jan/23 07:27
• Resolved: 07/Feb/19 16:04

Description

I would request removing -Wconversion from the CI build flags. It is overly finicky, generating errors for things such as converting a size_t to double. Furthermore, gbenchmark fails building with it, making it difficult to exercise locally.

I will mention that MSVC's conversion warnings are vastly more reasonable.