[ARROW-3487] [Gandiva] simplify NULL_IF_NULL functions that can return errors

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Component/s: C++ - Gandiva
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/19806
• Assignee: Pindikura Ravindra
• Reporter: Pindikura Ravindra
• Created: 11/Oct/18 10:58
• Updated: 11/Jan/23 07:27
• Resolved: 26/Oct/18 09:51

Description

NULL_IF_NULL functions that can return errors eg. divide currently look at the validity bits in each function (to avoid returning spurious errors).

 

divide(TYPE in1, boolean is_valid1, TYPE in2, boolean is_valid2, ..) {
    if (!is_valid1 || !is_valid2) { 
      return 0;
    }
    if (in2 == 0) { /* set error */ }
}

 

This validity check is duplicated for multiple functions and should be moved to the common layer (for all NULL_IF_NULL functions that can return error).

 

 

Issue Links

• links to: GitHub Pull Request #2840