Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2720

[C++] Clean up cmake CXX_STANDARD and PIC flag setting

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.12.0
    • C++

    Description

      We're using -std=c++11 in a few non-external project places as well as setting -fPIC. CMake provides the CMAKE_CXX_STANDARD flag (which we are also using) and the CMAKE_POSITION_INDEPENDENT_CODE flag for setting these options in a cross platform way (where it matters).

      We should use these flags instead of using platform conditional checks to set their values explicitly.

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              cpcloud Phillip Cloud
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h