[ARROW-187] [C++] Decide on how pedantic we want to be about exceptions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6.0
• Component/s: C++
• External issue URL: https://github.com/apache/arrow/issues/15537
• Assignee: Wes McKinney
• Reporter: Micah Kornfield
• Created: 02/May/16 04:53
• Updated: 11/Jan/23 07:07
• Resolved: 31/Jul/17 22:55

Description

We currently have code sprinkled around constructors that can technically fail because we either do a memcpy/allocation via vector copy constructor (we might be using a move constructor in places) and make_shared<>.

These are very small memory allocations but they can throw std::bad_alloc.

Technically, we would need to convert these to use Init or static factories.

(types.h is one place to look)