[ARROW-18319] `binary_replace_slice` should not work with `string` types

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: C++
• External issue URL: https://github.com/apache/arrow/issues/33490
• Assignee: Unassigned
• Reporter: Kshiteej K
• Created: 14/Nov/22 13:50
• Updated: 11/Jan/23 11:59

Description

`binary_replace_slice` can give in invalid output when used with string types. Given that there is `utf8_replace_slice`, I think `binary_replace_slice` should not support string types.

If a user actually wants to play with bytes for string type, they should explicitly cast to binary type and use `binary_replace_slice`.

>>> pc.binary_replace_slice(["hé"], 1, 2, "x")
<pyarrow.lib.StringArray object at 0x7fdbc09937c0>
[
  "hx�"
]
>>> pc.binary_replace_slice(["hé"], 1, 2, "x").validate(full=True)
Traceback (most recent call last):
  ...
ArrowInvalid: Invalid UTF8 sequence at string index 0 

Ref: https://github.com/apache/arrow/pull/14550#discussion_r1021545816

 

cc: apitrou