[ARROW-18018] [C++] Potential segmentation fault in unit tests due to usage of AllComplete instead of AllFinished

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/33221
• Assignee: Weston Pace
• Reporter: Weston Pace
• Created: 12/Oct/22 22:36
• Updated: 11/Jan/23 11:57
• Resolved: 13/Oct/22 11:37

Description

Many unit tests rely on StartAndCollect which was running AllComplete on two futures. The first was the plan finished future and the second was the sink generator collector future. However, AllComplete exits early if one of these futures fails. There were some cases where an error was delivered to the sink generator (and thus triggers that future) before the plan finished future was marked complete. This was generally quite rare but could lead to the plan getting deleted before all tasks had completely finished and it could sometimes lead to a segmentation fault.

The solution is to simply use AllFinished here as AllFinished waits for all futures to finish regardless of status.

Issue Links

• links to: GitHub Pull Request #14393