[ARROW-17823] [C++] Prefer std::make_shared/std::make_unique over constructor with new

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0.0
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/33045
• Assignee: Jin Shang
• Reporter: Jin Shang
• Created: 23/Sep/22 06:30
• Updated: 11/Jan/23 11:55
• Resolved: 24/Sep/22 20:16

Description

Advantage: readabilty, exception safety and efficiency(only for shared_ptr).

Cases that don't apply: When calling a private/protected constructor within class member function, make_shared/unique can't work.

Issue Links

• links to: GitHub Pull Request #14216
• links to: GitHub Pull Request #14233
• links to: GitHub Pull Request #15108