[ARROW-17803] [C++] Use [[nodiscard]]

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/33027
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 21/Sep/22 15:20
• Updated: 11/Jan/23 11:55
• Resolved: 22/Sep/22 14:59

Description

We currently have a ARROW_MUST_USE_TYPE macro that's only enabled on clang-based builds.
Instead we can use the [[nodiscard]] that's standard in C++17.

Issue Links

• is a child of: ARROW-17547 [C++] Adopt C++17 idioms and features for maintainability
• links to: GitHub Pull Request #14193