[ARROW-17686] [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/32925
• Assignee: Percy Camilo Triveño Aucahuasi
• Reporter: Weston Pace
• Created: 12/Sep/22 16:44
• Updated: 11/Jan/23 11:52
• Resolved: 21/Sep/22 08:18

Description

Valgrind is currently failing on arrow-compute-asof-join-node-test: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118

The issue appears to be that AsofJoinBasicParams has no gtest printer and so gtest is using the default universal-printer which doesn't really play well with valgrind. We should add a custom PrintTo method for AsofJoinBasicParams per: https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h

Issue Links

• links to: GitHub Pull Request #14172