[ARROW-17659] [Java] Populate JDBC schema name metadata when config.shouldIncludeMetadata provided

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0.0
• Fix Version/s: 10.0.0
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/32900
• Assignee: Igor Suhorukov
• Reporter: Igor Suhorukov
• Created: 09/Sep/22 09:05
• Updated: 11/Jan/23 11:52
• Resolved: 21/Sep/22 20:44

Description

Current implementation include catalog,table,column,type metadata, but schema metadata field is missing. In terms of PostgreSQL catalog - is database, schema - namespace inside database, so catalog name is insufficient for table addressing without schema.

 

Proposed changes is:

metadata.put(Constants.SQL_CATALOG_NAME_KEY, rsmd.getCatalogName(i));
metadata.put(Constants.SQL_SCHEMA_KEY, rsmd.getSchemaName(i));
metadata.put(Constants.SQL_TABLE_NAME_KEY, rsmd.getTableName(i));
metadata.put(Constants.SQL_COLUMN_NAME_KEY, columnName);
metadata.put(Constants.SQL_TYPE_KEY, rsmd.getColumnTypeName(i));

But this fix required to change assertions for metadata checks in many tests in arrow-jdbc module

Issue Links

• links to: GitHub Pull Request #14196